[PATCH] D102217: [COFF] Fix ARM and ARM64 REL32 relocations to be relative to the end of the relocation

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 23:38:08 PDT 2021


mstorsjo added inline comments.


================
Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:837
       // branches are offset by 4.
       FixedValue = FixedValue + 4;
       break;
----------------
rnk wrote:
> This is kind of the same thing. There's probably a refactoring here, but not without lots of surgery to the comments.
Yeah, I'm leaving that out as a potential future improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102217/new/

https://reviews.llvm.org/D102217



More information about the llvm-commits mailing list