[PATCH] D102217: [COFF] Fix ARM and ARM64 REL32 relocations to be relative to the end of the relocation

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 11:03:06 PDT 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:837
       // branches are offset by 4.
       FixedValue = FixedValue + 4;
       break;
----------------
This is kind of the same thing. There's probably a refactoring here, but not without lots of surgery to the comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102217/new/

https://reviews.llvm.org/D102217



More information about the llvm-commits mailing list