[PATCH] D101875: [RISCV] Prefer to lower MC_GlobalAddress operands to .Lfoo$local

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D101875#2751448 <https://reviews.llvm.org/D101875#2751448>, @jrtc27 wrote:

> In D101875#2751443 <https://reviews.llvm.org/D101875#2751443>, @MaskRay wrote:
>
>> In D101875#2751397 <https://reviews.llvm.org/D101875#2751397>, @jrtc27 wrote:
>>
>>> Ok, but you _still_ haven't wrapped the RUN lines like the example I posted
>>
>> Not sure this will improve readability. The longest RUN line just takes 99 characters. We don't enforce 80-character rule for tests.
>
> We enforce this uniform formatting in the RISC-V tests.

Quite a few `rvv/` tests have 100+-character RUN lines.

(There is a style disagreement on where `|` is inserted. In many tests `|` is placed at the end of the previous line while here `|` is placed at the beginning of the continuation line)

> Even though the line is short, splitting it makes it much easier to compare each RUN line.

To me it's different. Without interleaving wrapped `FileCheck` lines, it is easier to compare what options differ between two consecutive lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101875/new/

https://reviews.llvm.org/D101875