[PATCH] D101875: [RISCV] Prefer to lower MC_GlobalAddress operands to .Lfoo$local

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 11:08:09 PDT 2021


jrtc27 added a comment.

In D101875#2751443 <https://reviews.llvm.org/D101875#2751443>, @MaskRay wrote:

> In D101875#2751397 <https://reviews.llvm.org/D101875#2751397>, @jrtc27 wrote:
>
>> Ok, but you _still_ haven't wrapped the RUN lines like the example I posted
>
> Not sure this will improve readability. The longest RUN line just takes 99 characters. We don't enforce 80-character rule for tests.

We enforce this uniform formatting in the RISC-V tests. Even though the line is short, splitting it makes it much easier to compare each RUN line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101875/new/

https://reviews.llvm.org/D101875



More information about the llvm-commits mailing list