[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.

Tue May 11 10:53:02 PDT 2021

hgreving marked an inline comment as done.
hgreving added a comment.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17919
         ST->isUnindexed() && ST->isSimple() &&
+        Ld->getAddressSpace() == ST->getAddressSpace() &&
         // There can't be any side effects between the load and store, such as
----------------
jrtc27 wrote:
> Should this be weakened using `isNoopAddrSpaceCast` both(?) ways round?
I am actually not sure about the _exact_ semantics of isNoopAddrSpaceCast(). Does it imply that if true, it is a complete nop w.r.t. the memory model?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102096/new/

https://reviews.llvm.org/D102096