[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 10:33:56 PDT 2021


jrtc27 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17919
         ST->isUnindexed() && ST->isSimple() &&
+        Ld->getAddressSpace() == ST->getAddressSpace() &&
         // There can't be any side effects between the load and store, such as
----------------
Should this be weakened using `isNoopAddrSpaceCast` both(?) ways round?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102096/new/

https://reviews.llvm.org/D102096



More information about the llvm-commits mailing list