[PATCH] D101831: [AArch64][SVE] Add unpredicated vector BIC ISD node

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 07:44:33 PDT 2021


paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:3221
+  if (auto CNode = dyn_cast<ConstantSDNode>(N)) {
+    uint64_t ImmVal = ~CNode->getZExtValue();
+    SDLoc DL(N);
----------------
This looks to be the only difference to `SelectSVELogicalImm` so I wondered if it's better to extend  `SelectSVELogicalImm` with an `Invert` parameter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101831/new/

https://reviews.llvm.org/D101831



More information about the llvm-commits mailing list