[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.

Tue May 11 00:20:48 PDT 2021

RKSimon added a comment.

In D102096#2749297 <https://reviews.llvm.org/D102096#2749297>, @hgreving wrote:

> In D102096#2748611 <https://reviews.llvm.org/D102096#2748611>, @spatel wrote:
>
>> Code changes LG. 
>> I'd still prefer for the tests to go in first, so we have a regression test record of the miscompiles. Let me know if the suggestion was missed or isn't clear.
>
> I did miss this comment. Could you clarify, do you want me to commit the failing test, or a passing version with a FIXME?

@spatel meant the passing version (current trunk codegen) with a FIXME - you then rebase so this patch shows the codegen diffs - its easier to handle if you auto generate the checks with the update scripts.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102096/new/

https://reviews.llvm.org/D102096