[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.

Hendrik Greving via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 16:26:15 PDT 2021


hgreving added a comment.

In D102096#2748611 <https://reviews.llvm.org/D102096#2748611>, @spatel wrote:

> Code changes LG. 
> I'd still prefer for the tests to go in first, so we have a regression test record of the miscompiles. Let me know if the suggestion was missed or isn't clear.

I did miss this comment. Could you clarify, do you want me to commit the failing test, or a passing version with a FIXME?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102096/new/

https://reviews.llvm.org/D102096



More information about the llvm-commits mailing list