[PATCH] D102205: CodeGen: Make all passes preserve MachineOptimizationRemarkEmitterPass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D102205#2749491 <https://reviews.llvm.org/D102205#2749491>, @aeubanks wrote:

>   /// The analysis pass
>   ///
>   /// Note that this pass shouldn't generally be marked as preserved by other
>   /// passes.  It's holding onto BFI, so if the pass does not preserve BFI, BFI
>   /// could be freed.
>   class MachineOptimizationRemarkEmitterPass : public MachineFunctionPass {
>
> are you sure this is correct?

I found a bug in some null checks for the BFI, but once that's fixed no tests fail (e.g. MachineBlockFrequencyInfo::getBlockProfileCount checks for null after deref)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102205/new/

https://reviews.llvm.org/D102205