[PATCH] D102205: CodeGen: Make all passes preserve MachineOptimizationRemarkEmitterPass

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 18:33:58 PDT 2021


aeubanks added a comment.

  /// The analysis pass
  ///
  /// Note that this pass shouldn't generally be marked as preserved by other
  /// passes.  It's holding onto BFI, so if the pass does not preserve BFI, BFI
  /// could be freed.
  class MachineOptimizationRemarkEmitterPass : public MachineFunctionPass {

are you sure this is correct?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102205/new/

https://reviews.llvm.org/D102205



More information about the llvm-commits mailing list