[PATCH] D102110: [Inliner] Fix noalias metadata handling for instructions simplified during cloning (PR50270)

Mon May 10 12:53:07 PDT 2021

jeroen.dobbelaere accepted this revision.
jeroen.dobbelaere added a comment.
This revision is now accepted and ready to land.

In D102110#2748594 <https://reviews.llvm.org/D102110#2748594>, @nikic wrote:

> In D102110#2747213 <https://reviews.llvm.org/D102110#2747213>, @jeroen.dobbelaere wrote:
>
>> Looks good. Could you also add the other example as a test case ?
>
> Both examples are already included in the test: `@caller` tests `PropagateCallSiteMetadata` and `@self_caller` tests `ScopedAliasMetadataDeepCloner::remap`.

Yes indeed. Not sure how I overlooked it.

>> I am wondering if we should extend the testcases with the `llvm.experimental.noalias.scope.decl`. I assume they got lost while reducing the testcases ?
>
> Done! I hadn't included them originally because they're not strictly necessary, but it does make sense to have them for clarity.

Thanks.

LGTM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102110/new/

https://reviews.llvm.org/D102110