[PATCH] D102110: [Inliner] Fix noalias metadata handling for instructions simplified during cloning (PR50270)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 10 12:21:08 PDT 2021


nikic added a comment.

In D102110#2747213 <https://reviews.llvm.org/D102110#2747213>, @jeroen.dobbelaere wrote:

> Looks good. Could you also add the other example as a test case ?

Both examples are already included in the test: `@caller` tests `PropagateCallSiteMetadata` and `@self_caller` tests `ScopedAliasMetadataDeepCloner::remap`.

> I am wondering if we should extend the testcases with the `llvm.experimental.noalias.scope.decl`. I assume they got lost while reducing the testcases ?

Done! I hadn't included them originally because they're not strictly necessary, but it does make sense to have them for clarity.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102110/new/

https://reviews.llvm.org/D102110



More information about the llvm-commits mailing list