[PATCH] D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss marked an inline comment as done.
danielkiss added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/IndirectThunks.h:31
+  void createThunkFunction(MachineModuleInfo &MMI, StringRef Name,
+                           bool Comdat = true);
 
----------------
tamas.petz wrote:
> Is the default argument really required?
yes, this function is called from x86 backed and I'd not change that.


================
Comment at: llvm/include/llvm/CodeGen/IndirectThunks.h:57
+    F->setVisibility(GlobalValue::HiddenVisibility);
+    F->setComdat(M.getOrInsertComdat(Name));
+  }
----------------
tamas.petz wrote:
> There are still TABs there.
I think these are spaces, could you please take a look at the raw diff? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100546/new/

https://reviews.llvm.org/D100546