[PATCH] D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible

[Tamas Petz via Phabricator via llvm-commits]

tamas.petz added a comment.

I have just a few small comments.



================
Comment at: llvm/include/llvm/CodeGen/IndirectThunks.h:31
+  void createThunkFunction(MachineModuleInfo &MMI, StringRef Name,
+                           bool Comdat = true);
 
----------------
Is the default argument really required?


================
Comment at: llvm/include/llvm/CodeGen/IndirectThunks.h:57
+    F->setVisibility(GlobalValue::HiddenVisibility);
+    F->setComdat(M.getOrInsertComdat(Name));
+  }
----------------
There are still TABs there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100546/new/

https://reviews.llvm.org/D100546