[PATCH] D102096: [DAGCombiner] Fix DAG combine store elimination, different address space.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 10 04:47:06 PDT 2021
RKSimon added inline comments.
================
Comment at: llvm/test/CodeGen/X86/fs_gs_dag_combine.ll:3
+
+; Checks that the store is not eliminated by the DAG combiner.
+
----------------
very pedantic but maybe call this file dagcombine-dead-store.ll? That matches similar files in the folder. Then improve the comment here to explain that the address spaces are different and the stores shouldn't be eliminated?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102096/new/
https://reviews.llvm.org/D102096
More information about the llvm-commits
mailing list