[PATCH] D102137: [lld-macho] Don't reference entry symbol for non-executables

[Greg McGary via Phabricator via llvm-commits]

gkm added a comment.

LGTM!



================
Comment at: lld/MachO/Config.h:76
 struct Configuration {
-  Symbol *entry;
+  Symbol *entry = nullptr;
   bool hasReexports = false;
----------------
Nit: The name `entry` is too generic.


================
Comment at: lld/test/MachO/bundle-loader.s:12
+## Check bundle.bundle to ensure the `my_func` symbol is from executable
 # RUN: llvm-nm -m %t/bundle.bundle |  FileCheck %s --check-prefix BUNDLE
 # BUNDLE: (undefined) external my_func (from executable)
----------------



================
Comment at: lld/test/MachO/entry-symbol.s:10
 # CHECK-LABEL: SYMBOL TABLE
-# CHECK-NEXT: {{0*}}[[#%x, ENTRY_ADDR:]] {{.*}} __TEXT,__text _not_main
+# CHECK:       {{0*}}[[#%x, ENTRY_ADDR:]] {{.*}} __TEXT,__text _not_main
 # CHECK:      sectname __text
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102137/new/

https://reviews.llvm.org/D102137