[PATCH] D101972: Do not set CMAKE_CXX_VISIBILITY_PRESET to hidden

[Davide Cavalca via Phabricator via llvm-commits]

dcavalca added a comment.

FYI, without this patch we're seeing consistent test failures when building LLVM 12 in CentOS Stream 8:

  Failed Tests (10):
    LLVM-Unit :: IR/./IRTests/CGSCCCallbacksTest.InstrumentedInvalidatingPasses
    LLVM-Unit :: IR/./IRTests/CGSCCCallbacksTest.InstrumentedPasses
    LLVM-Unit :: IR/./IRTests/CGSCCCallbacksTest.InstrumentedSkippedPasses
    LLVM-Unit :: IR/./IRTests/FunctionCallbacksTest.InstrumentedPasses
    LLVM-Unit :: IR/./IRTests/FunctionCallbacksTest.InstrumentedSkippedPasses
    LLVM-Unit :: IR/./IRTests/LoopCallbacksTest.InstrumentedInvalidatingLoopNestPasses
    LLVM-Unit :: IR/./IRTests/LoopCallbacksTest.InstrumentedInvalidatingPasses
    LLVM-Unit :: IR/./IRTests/LoopCallbacksTest.InstrumentedPasses
    LLVM-Unit :: IR/./IRTests/LoopCallbacksTest.InstrumentedSkippedPasses
    LLVM-Unit :: IR/./IRTests/ModuleCallbacksTest.InstrumentedSkippedPasses

See https://cbs.centos.org/koji/taskinfo?taskID=2483905 for logs and https://bugzilla.redhat.com/show_bug.cgi?id=1952248 for more details. Thanks @tstellar for pointing out this fix!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101972/new/

https://reviews.llvm.org/D101972