[PATCH] D101972: Do not set CMAKE_CXX_VISIBILITY_PRESET to hidden

Fri May 7 12:37:56 PDT 2021

rnk added a comment.

In D101972#2743698 <https://reviews.llvm.org/D101972#2743698>, @serge-sans-paille wrote:

> https://github.com/llvm/llvm-project/blob/d480f968ad8b56d3ee4a6b6df5532d485b0ad01e/libcxx/include/any#L159
>
> This is what libcxx does for `std::any` when rti is not available.

Right, `_LIBCPP_TEMPLATE_VIS` presumably expands to `__attribute__((visibility("default")))`. I think it's reasonable to go ahead and do the same thing in LLVM. Enabling RTTI and using typeid is probably the only way to make this work well in the general case.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101972/new/

https://reviews.llvm.org/D101972