[PATCH] D101992: AMDGPU/GlobalISel: Use destination register bank in applyMappingLoad

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/load-constant.96.ll:449-452
+; GFX7-UNALIGNED-NEXT:    s_mov_b32 s2, -1
+; GFX7-UNALIGNED-NEXT:    s_mov_b32 s3, 0xf000
+; GFX7-UNALIGNED-NEXT:    buffer_load_dwordx3 v[0:2], off, s[0:3], 0
+; GFX7-UNALIGNED-NEXT:    s_waitcnt vmcnt(0)
----------------
arsenm wrote:
> This looks like an accidental bug fix
Why is it a bug fix? Isn't it better to use a scalar load when possible, cos it's less memory traffic?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101992/new/

https://reviews.llvm.org/D101992