[PATCH] D101896: [lit] Report tool path from use_llvm_tool if found via env variable

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/utils/lit/tests/use-tool-search-env.py:7
+
+# CHECK: note: using test-tool: [[DIR]]{{[\\/]}}Inputs{{[\\/]}}use-tool-search-env{{[\\/]}}test.tool
----------------
daltenty wrote:
> Looks like this test has issues if the path has a symlink in it, we may need to call realpath somewhere?
> 
> https://lab.llvm.org/staging/#/builders/126/builds/345/steps/5/logs/FAIL__lit___use-tool-search-env_py
> 
> (/home/powerllvm/powerllvm_env/aix-ppc64-ppc64le/clang-ppc64-aix-ppc64le/ is symlinked to /scratch/powerllvm/powerllvm_env/aix-ppc64-ppc64le/clang-ppc64-aix-ppc64le on the AIX builder)
Thanks. I've pushed a likely fix (see rGd2b2ad32b76989b68e7b525e7484e25b0f0cc4e6), but don't have an environment where I can easily verify it. I'll keep an eye on the build bot, but if my fix doesn't resolve the issue, I'll need someone else to take a look at it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101896/new/

https://reviews.llvm.org/D101896