[PATCH] D101896: [lit] Report tool path from use_llvm_tool if found via env variable

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 6 20:09:06 PDT 2021


daltenty added inline comments.


================
Comment at: llvm/utils/lit/tests/use-tool-search-env.py:7
+
+# CHECK: note: using test-tool: [[DIR]]{{[\\/]}}Inputs{{[\\/]}}use-tool-search-env{{[\\/]}}test.tool
----------------
Looks like this test has issues if the path has a symlink in it, we may need to call realpath somewhere?

https://lab.llvm.org/staging/#/builders/126/builds/345/steps/5/logs/FAIL__lit___use-tool-search-env_py

(/home/powerllvm/powerllvm_env/aix-ppc64-ppc64le/clang-ppc64-aix-ppc64le/ is symlinked to /scratch/powerllvm/powerllvm_env/aix-ppc64-ppc64le/clang-ppc64-aix-ppc64le on the AIX builder)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101896/new/

https://reviews.llvm.org/D101896



More information about the llvm-commits mailing list