[PATCH] D101972: Do not set CMAKE_CXX_VISIBILITY_PRESET to hidden

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D101972#2742314 <https://reviews.llvm.org/D101972#2742314>, @tstellar wrote:

> I also would really like to see more of LLVM with hidden visibility too.  My main concern with this issue is that without some kind of enforcement in place, this same code pattern is going to get reintroduced somewhere else in the codebase. and debugging this issue was very costly.  Do you have any ideas for how we might be able to ensure this pattern doesn't re-emerge?

I don't have any brilliant ideas other than developer education. This is just one of those weird portable development things that you need to know as a C++ developer. It's a difference between C++ as it is standardized and C++ as it works in practice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101972/new/

https://reviews.llvm.org/D101972