[PATCH] D101972: Do not set CMAKE_CXX_VISIBILITY_PRESET to hidden

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 6 12:40:12 PDT 2021


serge-sans-paille added a comment.

@rnk it's used in the newPassManager. forcing the visibility of llvm::Any indeed fixes the bug I met (that was my original patch), but I also understand the concern of @tstellar concerning the possibility of having similar issue across the code base. A possible way to solve the issue the hard way would be to design a clang warning / a static analysis that spots this kind of issues. Thinking of it, maybe the check could be done at link time to, or on the final shared library?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101972/new/

https://reviews.llvm.org/D101972



More information about the llvm-commits mailing list