[PATCH] D101992: AMDGPU/GlobalISel: Use destination register bank in applyMappingLoad

[Petar Avramovic via Phabricator via llvm-commits]

Petar.Avramovic added a comment.

This was detected on gfx7 on large test (few hundred lines) with many uniform loads.
Loads in first ~200 lines had amdgpu.noclobber but after some threshold they did not.
AnnotateUniformValues was relying on MemoryDependenceResults::getSimplePointerDependencyFrom which gives up at some point and returns MemDepResult::getUnknown() resulting in amdgpu.noclobber not being set on address. Such load will be selected using vgpr destination (and sgpr address on gfx7).
In the case of mentioned test, amdgpu.noclobber not being set is fixed by D101962 <https://reviews.llvm.org/D101962>. Thus only mir test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101992/new/

https://reviews.llvm.org/D101992