[PATCH] D101866: [BPF][Test] Use mtriple instead of march

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 17:07:06 PDT 2021


jsji added a comment.

In D101866#2740729 <https://reviews.llvm.org/D101866#2740729>, @yonghong-song wrote:

> If I understand correctly, on AIX system, BPF is not supported, so if -march=bpf is specified,  it will internally expand to -mtriple=bpfel-ibm-aix and the test will fail since it is not supported, if llc uses -mtriple=bpfel and then llvm understands it is not really related to AIX and it is fine, is that right?

Yes, it is correct.

> I don't like to change all tests (-march ==> -mtriple) for unsupported platform. Other platforms e.g., macos/windows seems working fine, could you check how they did?

Toolchain can choose whether they want to override the default handling of triple.  AIX toolchain choose not to override and use the default one.

> In the worst case, if what windows/macos did won't work for you, you could change BPF test directory lit.local.cfg file to mark `config.unsupported = True` in your platform, but not individual tests.

That is fine for us if you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101866/new/

https://reviews.llvm.org/D101866



More information about the llvm-commits mailing list