[PATCH] D101866: [BPF][Test] Use mtriple instead of march

Yonghong Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 16:40:32 PDT 2021


yonghong-song added a comment.

If I understand correctly, on AIX system, BPF is not supported, so if -march=bpf is specified,  it will internally expand to -mtriple=bpfel-ibm-aix and the test will fail since it is not supported, if llc uses -mtriple=bpfel and then llvm understands it is not really related to AIX and it is fine, is that right?

I don't like to change all tests (-march ==> -mtriple) for unsupported platform. Other platforms e.g., macos/windows seems working fine, could you check how they did?
In the worst case, if what windows/macos did won't work for you, you could change BPF test directory lit.local.cfg file to mark `config.unsupported = True` in your platform, but not individual tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101866/new/

https://reviews.llvm.org/D101866



More information about the llvm-commits mailing list