[PATCH] D101446: [llvm] Improve export.sh with help and snapshot
Aaron Puchert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 5 15:40:26 PDT 2021
aaronpuchert added a comment.
> This is useful for creating daily snapshot tarballs that can easily be consumed by packagers who want to build a daily snapshot.
My understanding (derived from the containing directory's name) is that this script is used for creating the official release tarballs to be published on `releases.llvm.org` or GitHub. Are there plans to publish snapshots?
Short of that it's just a "create tarball for a given git hash", which isn't really LLVM-specific. Packagers will often have their own preferred way of creating snapshots, e.g. in Open Build Service <https://openbuildservice.org/> I'd use a source service to create the snapshots automatically.
But that's not up to me. If @hans and @tstellar are fine with this, it's good to go.
In D101446#2738274 <https://reviews.llvm.org/D101446#2738274>, @hans wrote:
> Is having <yyyymmdd> in the filename really the most useful thing. I'd imagine having the git ref directly might be more useful, or perhaps the output of "git-describe" on it. Or maybe it should have both the git-ref and date in the filename?
Makes sense to me, after all the result should ideally be reproducible. (Prior to compression at least.)
================
Comment at: llvm/utils/release/export.sh:91-97
+ tag="llvmorg-$release"
+
+ if [ "$rc" = "final" ]; then
+ rc=""
+ else
+ tag="$tag-$rc"
+ fi
----------------
Seems like this duplicates 77-83, maybe remove those lines?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101446/new/
https://reviews.llvm.org/D101446
More information about the llvm-commits
mailing list