[PATCH] D101446: [llvm] Improve export.sh with help and snapshot

Wed May 5 02:06:16 PDT 2021

hans added a comment.

Is having <yyyymmdd> in the filename really the most useful thing. I'd imagine having the git ref directly might be more useful, or perhaps the output of "git-describe" on it. Or maybe it should have both the git-ref and date in the filename?
And when using the date, perhaps it should use the date of the commit (commitdate, not authordate i guess) rather than the date when the script is run?
Or maybe the script should take a template argument for the filenames?

================
Comment at: llvm/utils/release/export.sh:37
+                      [-final|--final]
+                      [-snapshot|--snapshot <git-ref>] 
+
----------------
The test-release.sh script (and maybe others?) have a "-git-ref" option. Maybe that's a better name than "-snapshot", for consistency?

================
Comment at: llvm/utils/release/export.sh:57
+
+Additional files being generated:
+
----------------
Additional to what?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101446/new/

https://reviews.llvm.org/D101446