[PATCH] D96883: Add support for JSON output style to llvm-symbolizer
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 5 14:33:06 PDT 2021
dblaikie added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:99-100
+
+ void listBegin() override{};
+ void listEnd() override{};
};
----------------
aorlov wrote:
> jhenderson wrote:
> > Is this clang-formatted properly? Slightly surprised there's no space after `override`.
> It is generated by clang-format and validated by clang-tidy.
The extraneous trailing semicolon is probably confusing clang-format, so maybe remove those and see how it gets formatted?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96883/new/
https://reviews.llvm.org/D96883
More information about the llvm-commits
mailing list