[PATCH] D96883: Add support for JSON output style to llvm-symbolizer

[Alex Orlov via Phabricator via llvm-commits]

aorlov marked 7 inline comments as done.
aorlov added a comment.

> I think adding source context can be a later patch. Let's try to avoid adding more than we have to in this one patch.

Nice.
Note you asked for a new test for `Source` a week ago.
Ok, I have removed `Source` from the JSON output and removed the new test for `Source`.

I have restored output-style-json-frame.test instead of output-style-json-frame.c
Note output-style-json-frame.test is huge because it is machine generated and you asked for a non zero and non empty `TagOffset`.
I don't like an idea to clean up or optimize it anyway.



================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:99-100
+
+  void listBegin() override{};
+  void listEnd() override{};
 };
----------------
jhenderson wrote:
> Is this clang-formatted properly? Slightly surprised there's no space after `override`.
It is generated by clang-format and validated by clang-tidy.


================
Comment at: llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp:238
+    const DILineInfo &LI = Info.getFrame(I);
+    json::Object O(
+        {{"FunctionName",
----------------
jhenderson wrote:
> `Object` maybe?
It is not necessary anymore because `Source` has been removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96883/new/

https://reviews.llvm.org/D96883