[PATCH] D101828: [AArch64][SVE] Better utilisation of unpredicated forms of remaining intrinsics

Joe Ellis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 03:55:45 PDT 2021


joechrisellis accepted this revision.
joechrisellis added a comment.
This revision is now accepted and ready to land.

One nit, otherwise LGTM.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13880
+                                       SelectionDAG &DAG,
+                                       bool UnpredOp = false) {
   assert(N->getOpcode() == ISD::INTRINSIC_WO_CHAIN && "Expected intrinsic!");
----------------
nit: double negative -- I think the code would read better if this was `PredicatedOp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101828/new/

https://reviews.llvm.org/D101828



More information about the llvm-commits mailing list