[PATCH] D101796: [llvm-objdump] Improve newline consistency between different pieces of information

Tue May 4 01:52:47 PDT 2021

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Generally looks good to me. Are all the changes covered by testing? I struggled a little to follow the impact of the changes, and didn't necessarily see the sort of testing I'd have expected, given the changes (e.g. "Dynamic Section:" preceded by a `CHECK-EMPTY` or equivalent).

================
Comment at: llvm/test/tools/llvm-objdump/all-headers.test:13-14
 # CHECK-EMPTY:
 # CHECK-NEXT: Program Header:
-# CHECK: Dynamic Section:
-# CHECK: Sections:
+# CHECK:       Dynamic Section:
+# CHECK:         INIT
----------------
Indentation looks a bit off between these two lines.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101796/new/

https://reviews.llvm.org/D101796