[PATCH] D101796: [llvm-objdump] Improve newline consistency between different pieces of information

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: jhenderson, thakis.
Herald added subscribers: kerbowa, rupprecht, nhaehnle, jvesely, emaste.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When dumping multiple pieces of information (e.g. --all-headers),
there is sometimes no separator between two pieces.
This patch uses the "\nheader:\n" style, which generally improves
compatibility with GNU objdump.

Note: objdump -t/-T does not add a newline before "SYMBOL TABLE:" and "DYNAMIC SYMBOL TABLE:".
We add a newline to be consistent with other information.

`objdump -d` prints two empty lines before the first 'Disassembly of section'.
We print just one with this patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101796

Files:
  lld/test/MachO/arm64-32-reloc-got-load.s
  lld/test/MachO/arm64-reloc-got-load.s
  lld/test/MachO/arm64-reloc-tlv-load.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-failure.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-sgpr.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-vgpr.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-gfx9.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-raw.s
  llvm/test/tools/llvm-objdump/ELF/symbol-table.test
  llvm/test/tools/llvm-objdump/ELF/verdef.test
  llvm/test/tools/llvm-objdump/ELF/verneed.test
  llvm/test/tools/llvm-objdump/MachO/section-headers.test
  llvm/test/tools/llvm-objdump/X86/disassemble-section-name.s
  llvm/test/tools/llvm-objdump/X86/elf-dynamic-symbols.test
  llvm/test/tools/llvm-objdump/all-headers.test
  llvm/tools/llvm-objdump/ELFDump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101796.342580.patch
Type: text/x-patch
Size: 17040 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210503/4e3bf5f8/attachment.bin>