[PATCH] D99434: [TSAN] Honor acquire failure mode on AtomicCAS

Bruno Cardoso Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 15:08:20 PDT 2021


bruno updated this revision to Diff 342557.
bruno marked an inline comment as done and an inline comment as not done.
bruno edited the summary of this revision.
bruno added a comment.

Apply review comments.

Note that we cannot test mo == relaxed and fmo == anything yet because LLVM fallbacks to relaxed/relaxed.

Remove the dep on https://reviews.llvm.org/D101501 for now, since there's even more stuff to improve in LLVM before we get this 100% right, at least we've got release/acquire working as of this patch. I'll come back to fix the other tests once LLVM is fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99434/new/

https://reviews.llvm.org/D99434

Files:
  compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp
  compiler-rt/test/tsan/compare_exchange.cpp
  llvm/test/Instrumentation/ThreadSanitizer/atomic.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99434.342557.patch
Type: text/x-patch
Size: 6104 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210503/295423d7/attachment.bin>


More information about the llvm-commits mailing list