[PATCH] D101115: [AMDGPU] Move code sinking before structurizer

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

In D101115#2712423 <https://reviews.llvm.org/D101115#2712423>, @piotr wrote:

> In D101115#2711972 <https://reviews.llvm.org/D101115#2711972>, @piotr wrote:
>
>> In D101115#2711964 <https://reviews.llvm.org/D101115#2711964>, @arsenm wrote:
>>
>>> In D101115#2711462 <https://reviews.llvm.org/D101115#2711462>, @piotr wrote:
>>>
>>>> I know it is a legacy pass, but I am convinced of its usefulness in our flow - both in real-world content and lit testing (e.g., no_skip_no_successors in skip-if-dead.ll).
>>>
>>> I'm not worried about legacy, but whether it's redundant since it should have already run at this point
>>
>> Some sinking is done as part of other passes, but I do not think this pass is set up to be run at any other point in our pass list.
>
> @foad helped me understand what you mean (thanks). Yes, this pass should be part of the opt pipeline, but currently we rely on it being run in the codegen pipeline. I do not know the history of that, but Mesa also needs it here.

The backend isn't responsible for adding all the general optimization passes, only cases where we might want them to cleanup other lowering or late optimizations. I don't remember why this ended up here but moving it is fine


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101115/new/

https://reviews.llvm.org/D101115