[PATCH] D101405: [AMDGPU] Change FLAT SADDR to VADDR form in moveToVALU

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 28 09:12:04 PDT 2021


Joe_Nash added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5037
+  int OldVAddrIdx = AMDGPU::getNamedOperandIdx(Opc, AMDGPU::OpName::vaddr);
+  assert(OldVAddrIdx >= 0);
+
----------------
I don't understand why this assert is true. Does some previous check guarantee that? Other than that LGTM, but please wait for @arsenm 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101405/new/

https://reviews.llvm.org/D101405



More information about the llvm-commits mailing list