[PATCH] D101367: [AMDGPU] Serialize MFInfo::ScavengeFI

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne updated this revision to Diff 342012.
sebastian-ne marked an inline comment as done.
sebastian-ne added a comment.
Herald added subscribers: arphaman, mgorny.

> This is rougher than I would hope. This isn't a simple integer, it's a frame index. I would hope there would be some syntax to indicate this, and some validation that it is a valid frame object. There's no frame info here at all. e.g. I would expect a string here that looks like a frame index as it appears in an operand

Ah, I was already wondering why it felt so easy.
Now it uses the same form as in operands. The disadvantage is that a MachineFrameInfo is needed for serialization and deserialization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101367/new/

https://reviews.llvm.org/D101367

Files:
  llvm/include/llvm/CodeGen/MIRYamlMapping.h
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/MIRYamlMapping.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
  llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
  llvm/test/CodeGen/MIR/AMDGPU/invalid-frame-index.mir
  llvm/test/CodeGen/MIR/AMDGPU/invalid-frame-index2.mir
  llvm/test/CodeGen/MIR/AMDGPU/machine-function-info-after-pei.ll
  llvm/test/CodeGen/MIR/AMDGPU/machine-function-info-no-ir.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101367.342012.patch
Type: text/x-patch
Size: 12291 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210430/8bd8a6b6/attachment.bin>