[PATCH] D101367: [AMDGPU] Serialize MFInfo::ScavengeFI

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

The point that this is only used in PEI is interesting. That almost suggests it doesn't belong here at all but I'm not sure where else you would track it.



================
Comment at: llvm/test/CodeGen/MIR/AMDGPU/machine-function-info-no-ir.mir:352
+machineFunctionInfo:
+  scavengeFI: 5
+
----------------
This is rougher than I would hope. This isn't a simple integer, it's a frame index. I would hope there would be some syntax to indicate this, and some validation that it is a valid frame object. There's no frame info here at all. e.g. I would expect a string here that looks like a frame index as it appears in an operand


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101367/new/

https://reviews.llvm.org/D101367