[PATCH] D101588: [M68k] fix -Wdefaulted-function-deleted and -Woverloaded-virtual
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 30 12:29:02 PDT 2021
dblaikie added a comment.
@myhsu (or someone else with M68k familiarity) - the virtual function fix here is a semantic change (previously whatever was calling the virtual function would not have been getting the implementation it is now getting). Is there any testing that could be added to demonstrate that this semantic change is correct/avoid the regression/test the codepath that is missing coverage?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101588/new/
https://reviews.llvm.org/D101588
More information about the llvm-commits
mailing list