[llvm] 749702f - [AMDGPU] Remove dead early-out in GCNHazardRecognizer

Carl Ritson via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 16:57:06 PDT 2021


Author: Carl Ritson
Date: 2021-04-30T08:55:49+09:00
New Revision: 749702fc6ba268cb0096c09393db51a20bb5eb0d

URL: https://github.com/llvm/llvm-project/commit/749702fc6ba268cb0096c09393db51a20bb5eb0d
DIFF: https://github.com/llvm/llvm-project/commit/749702fc6ba268cb0096c09393db51a20bb5eb0d.diff

LOG: [AMDGPU] Remove dead early-out in GCNHazardRecognizer

Remove an early-out in wait state counting which can never be
taken.

Reviewed By: foad, rampitec

Differential Revision: https://reviews.llvm.org/D101520

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
index 82e1c58210b2e..57121ac286cd9 100644
--- a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
@@ -428,9 +428,6 @@ static int getWaitStatesSince(GCNHazardRecognizer::IsHazardFn IsHazard,
       continue;
 
     MinWaitStates = Found ? std::min(MinWaitStates, W) : W;
-    if (IsExpired(nullptr, MinWaitStates))
-      return MinWaitStates;
-
     Found = true;
   }
 


        


More information about the llvm-commits mailing list