[PATCH] D101558: [lld-macho] Parse & emit the N_ARM_THUMB_DEF symbol flag

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added a comment.

> LGTM ... except for the jarring introduction of an arch-specific bit into arch-independent code. Yet, N_ARM_THUMB_DEF already exists as an arch-dependent bit among the otherwise arch-independent symbol table flags, so I see no way around it.

Yup, I feel the same way, but the ABI is what it is.



================
Comment at: lld/MachO/Driver.cpp:521-522
     replaceSymbol<Defined>(sym, sym->getName(), isec->file, isec, /*value=*/0,
                            /*size=*/0,
                            /*isWeakDef=*/false,
+                           /*isExternal=*/true, common->privateExtern,
----------------
gkm wrote:
> Super nit.
this isn't up to me, it's clang-format :p 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101558/new/

https://reviews.llvm.org/D101558