[PATCH] D101558: [lld-macho] Parse & emit the N_ARM_THUMB_DEF symbol flag

Fri Apr 30 09:11:11 PDT 2021

gkm accepted this revision.
gkm added a comment.
This revision is now accepted and ready to land.

LGTM ... except for the jarring introduction of an arch-specific bit into arch-independent code. Yet, `N_ARM_THUMB_DEF` already exists as an arch-dependent bit among the otherwise arch-independent symbol table flags, so I see no way around it.

================
Comment at: lld/MachO/Driver.cpp:521-522
     replaceSymbol<Defined>(sym, sym->getName(), isec->file, isec, /*value=*/0,
                            /*size=*/0,
                            /*isWeakDef=*/false,
+                           /*isExternal=*/true, common->privateExtern,
----------------
Super nit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101558/new/

https://reviews.llvm.org/D101558