[PATCH] D101626: [TableGen] Fix two bugs in 'defm' when a complex 'assert' is involved

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 07:02:27 PDT 2021


Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/test/TableGen/assert.td:197
+// CHECK: note: MC5 name must include a space: Ada_Lovelace
+// CHECK: assertion failed
+// CHECK: note: person age is invalid: 666
----------------
jansvoboda11 wrote:
> I'd expect TableGen to report only the first assertion failure and abort immediately. What's the logic behind the current behavior?
Assertion failures are not fatal, so that other errors in the .td files can be reported at the same time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101626/new/

https://reviews.llvm.org/D101626



More information about the llvm-commits mailing list