[PATCH] D101626: [TableGen] Fix two bugs in 'defm' when a complex 'assert' is involved

Jan Svoboda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 06:54:35 PDT 2021


jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/TableGen/assert.td:197
+// CHECK: note: MC5 name must include a space: Ada_Lovelace
+// CHECK: assertion failed
+// CHECK: note: person age is invalid: 666
----------------
I'd expect TableGen to report only the first assertion failure and abort immediately. What's the logic behind the current behavior?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101626/new/

https://reviews.llvm.org/D101626



More information about the llvm-commits mailing list