[PATCH] D101593: [AArch64][SVE] Remove index_vector node.

[JunMa via Phabricator via llvm-commits]

junparser added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1371-1374
+  defm INDEX_RR : sve_int_index_rr<"index", step_vector, step_vector_oneuse, AArch64mul_p_oneuse>;
+  defm INDEX_IR : sve_int_index_ir<"index", step_vector, step_vector_oneuse, AArch64mul_p, AArch64mul_p_oneuse>;
+  defm INDEX_RI : sve_int_index_ri<"index", step_vector, step_vector_oneuse>;
+  defm INDEX_II : sve_int_index_ii<"index", step_vector, step_vector_oneuse>;
----------------
paulwalker-arm wrote:
> As a tidy up I'd say these multiclasses are intrinsically linked to stepvector and related nodes.  As these nodes now have a unified form I personally don't see much value with the indirection and think they can use all the operations directly within the multiclass.
Yep, It  maybe nice to move these Pat to here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101593/new/

https://reviews.llvm.org/D101593