[PATCH] D100284: [RISCV] Precommit a test case that test accessing a fixed object when has rvv vector object existed

[luxufan via Phabricator via llvm-commits]

StephenFan added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/localvar.ll:290
 
+define i64 @fixed_object(i64 %0, i64 %1, i64 %2, i64 %3, i64 %4, i64 %5, i64 %6, i64 %7, i64 %8) nounwind {
+; RV64IV-LABEL: fixed_object:
----------------
frasercrmck wrote:
> Maybe if this is wrong code add a little FIXME comment to explain what's wrong? Just in case your follow-up patch takes a while to land.
> Maybe if this is wrong code add a little FIXME comment to explain what's wrong? Just in case your follow-up patch takes a while to land.




================
Comment at: llvm/test/CodeGen/RISCV/rvv/localvar.ll:290
 
+define i64 @fixed_object(i64 %0, i64 %1, i64 %2, i64 %3, i64 %4, i64 %5, i64 %6, i64 %7, i64 %8) nounwind {
+; RV64IV-LABEL: fixed_object:
----------------
StephenFan wrote:
> frasercrmck wrote:
> > Maybe if this is wrong code add a little FIXME comment to explain what's wrong? Just in case your follow-up patch takes a while to land.
> > Maybe if this is wrong code add a little FIXME comment to explain what's wrong? Just in case your follow-up patch takes a while to land.
> 
> 
I'm sorry that I forgot your comment. Recently, the patch that fix this wrong code is accepted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100284/new/

https://reviews.llvm.org/D100284