[PATCH] D101025: [llvm-dwarfdump] Fix abstract origin vars location stats calculation

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 14:56:49 PDT 2021


dblaikie added a comment.

Sorry, I know this is annoying - but could you commit the renaming as a separate preliminary patch (feel free to commit that without review)? It'd make it much easier to understand the semantic change in this patch with that separated.



================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:225-226
+static void
+collectStatsForDie(DWARFDie Die, std::string FnPrefix, std::string VarPrefix,
+                   uint64_t BytesInScope, uint32_t InlineDepth,
+                   StringMap<PerFunctionStats> &FnStatMap,
----------------
Side note: why are we passing around std::strings by value? Should these be being passed by const ref? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101025/new/

https://reviews.llvm.org/D101025



More information about the llvm-commits mailing list