[PATCH] D101163: [AArch64] Prevent spilling between ldxr/stxr pairs

Thu Apr 29 12:57:03 PDT 2021

efriedma added a comment.

In D101163#2714366 <https://reviews.llvm.org/D101163#2714366>, @tschuett wrote:

> Another attempt:
> https://reviews.llvm.org/D101152

I don't think that patch addresses this issue.

================
Comment at: llvm/test/CodeGen/AArch64/atomicrmw-O0.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs -mtriple=aarch64-- -O0 -fast-isel=0 -global-isel=false %s -o - | FileCheck %s
+
----------------
Please add a RUN line with LSE enabled.

Please add a test for "nand".

================
Comment at: llvm/test/Transforms/AtomicExpand/AArch64/expand-atomicrmw-xchg-fp.ll:3
+; RUN: opt -O1 -S -mtriple=aarch64-- -atomic-expand %s | FileCheck %s
+; RUN: opt -O1 -S -mtriple=aarch64-- -mattr=+outline-atomics -atomic-expand %s | FileCheck %s --check-prefix=OUTLINE-ATOMICS

----------------
I don't think this change is necessary?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101163/new/

https://reviews.llvm.org/D101163