[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 08:24:25 PDT 2021


wingo added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4114
+
+    if (EltVT.isZeroSized())
+      A = Ptr;
----------------
Does this path actually fire for you?  In my local tests, if you are loading from EXTERNREF_GLOBAL, then the EltVT ends up being `i32`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/

https://reviews.llvm.org/D95425



More information about the llvm-commits mailing list